comphead commented on code in PR #17132: URL: https://github.com/apache/datafusion/pull/17132#discussion_r2268101959
########## dev/release/README.md: ########## @@ -128,6 +128,15 @@ release. See [#9697](https://github.com/apache/datafusion/pull/9697) for an example. +Modify `asf.yaml` to protect future release candidate branch to prevent accidental merges: + +```yaml +# needs to be updated as part of the release process +branch-50: Review Comment: > also, you sure patterns don't work? at least in branch protection rules they are actually working Github UI supports the wildcard, but `asf.yaml` surprisingly does not https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#branch-protection > I think hardcoding with a comment stating why we do that is reasonable. We can also do 10 or 15 years which IMO is probably enough, 100 is overkill. Agree, lets have 10-20 branches hardcoded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
