findepi commented on code in PR #17132:
URL: https://github.com/apache/datafusion/pull/17132#discussion_r2269300595
##########
.asf.yaml:
##########
@@ -50,6 +50,74 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ # needs to be updated as part of the release process
+ # Github doesn't support wildcard branch protection rules, only exact
branch names
Review Comment:
I believe GitHub does support that. At least I have set wildcard-based
protection rules in the past. Might it be that ASF automation does not?
##########
.github/workflows/extended.yml:
##########
@@ -32,6 +32,8 @@ on:
push:
branches:
- main
+ # release candidate branches
+ - 'branch-*'
Review Comment:
There are also `github.ref_name == 'main'` checks in the rust workflow.
Currently they look harmless, as they only conditionally enable "some cache"
(no sure what that cache is for...).
Maybe worth adding a code comment in these usages to make it less likely
someone will clopy-paste into a more important job step?
##########
.github/workflows/extended.yml:
##########
@@ -32,6 +32,8 @@ on:
push:
branches:
- main
+ # release candidate branches
+ - 'branch-*'
Review Comment:
Same in docs & audit workflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
