leung-ming commented on PR #2069:
URL:
https://github.com/apache/datafusion-comet/pull/2069#issuecomment-3177540741
> Is there an existing benchmark in the repo that you are using? If not,
could you add criterion benchmark so that we can see the performance
improvement from these changes?
`cargo bench --bench aggregate` on my laptop (U5 225H)
before
```
aggregate/sum_decimal_datafusion
time: [727.63 µs 749.34 µs 775.49 µs]
change: [−4.5771% −0.6272% +3.8215%] (p = 0.77 >
0.05)
No change in performance detected.
aggregate/sum_decimal_comet
time: [845.70 µs 865.20 µs 887.37 µs]
change: [−3.6157% −0.0210% +3.6665%] (p = 0.99 >
0.05)
No change in performance detected.
```
after
```
aggregate/sum_decimal_datafusion
time: [724.23 µs 732.84 µs 743.71 µs]
change: [−5.6988% −2.2014% +1.0739%] (p = 0.23 >
0.05)
No change in performance detected.
aggregate/sum_decimal_comet
time: [755.35 µs 766.43 µs 779.43 µs]
change: [−13.966% −11.415% −8.9387%] (p = 0.00 <
0.05)
Performance has improved.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
