Omega359 commented on PR #16877:
URL: https://github.com/apache/datafusion/pull/16877#issuecomment-3179469578
I ran benchmarks for this branch compared to main and I only see one very
small regression (StringArray_ascii_str_len_4096).
```
:/opt/dev/arrow-datafusion$ cargo bench --bench character_length --
--baseline main
Compiling datafusion-functions v49.0.0
(/opt/dev/arrow-datafusion/datafusion/functions)
Finished `bench` profile [optimized] target(s) in 49.92s
Running benches/character_length.rs
(target/release/deps/character_length-9d01ae18640969e5)
character_length_StringArray_ascii_str_len_8
time: [2.3217 µs 2.3338 µs 2.3499 µs]
change: [-70.168% -70.020% -69.870%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
1 (1.00%) high mild
1 (1.00%) high severe
character_length_StringArray_utf8_str_len_8
time: [108.42 µs 108.85 µs 109.33 µs]
change: [-4.1258% -2.0791% -0.3300%] (p = 0.03 <
0.05)
Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low mild
5 (5.00%) high mild
character_length_StringViewArray_ascii_str_len_8
time: [31.409 µs 31.547 µs 31.695 µs]
change: [-19.721% -19.346% -18.991%] (p = 0.00 <
0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
9 (9.00%) high mild
1 (1.00%) high severe
character_length_StringViewArray_utf8_str_len_8
time: [102.58 µs 104.39 µs 106.58 µs]
change: [-0.1171% +0.7305% +1.7003%] (p = 0.10 >
0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe
character_length_StringArray_ascii_str_len_32
time: [5.5538 µs 5.5731 µs 5.5943 µs]
change: [-54.118% -53.031% -52.101%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild
character_length_StringArray_utf8_str_len_32
time: [133.03 µs 133.56 µs 134.11 µs]
change: [-5.5034% -4.6092% -3.8204%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild
character_length_StringViewArray_ascii_str_len_32
time: [23.540 µs 23.930 µs 24.375 µs]
change: [-24.883% -24.224% -23.463%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe
character_length_StringViewArray_utf8_str_len_32
time: [152.93 µs 153.50 µs 154.14 µs]
change: [-1.8097% -0.0660% +1.4446%] (p = 0.94 >
0.05)
No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) low mild
4 (4.00%) high mild
1 (1.00%) high severe
character_length_StringArray_ascii_str_len_128
time: [18.674 µs 18.737 µs 18.807 µs]
change: [-23.516% -23.167% -22.798%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high mild
character_length_StringArray_utf8_str_len_128
time: [188.08 µs 191.04 µs 194.59 µs]
change: [-4.0435% -3.2065% -2.1545%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe
character_length_StringViewArray_ascii_str_len_128
time: [41.822 µs 41.954 µs 42.100 µs]
change: [-16.332% -15.373% -14.564%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
8 (8.00%) high mild
character_length_StringViewArray_utf8_str_len_128
time: [207.50 µs 208.24 µs 209.08 µs]
change: [-0.1220% +0.2909% +0.7264%] (p = 0.19 >
0.05)
No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
character_length_StringArray_ascii_str_len_4096
time: [938.17 µs 943.56 µs 950.96 µs]
change: [+1.1240% +2.5689% +3.9058%] (p = 0.00 <
0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe
character_length_StringArray_utf8_str_len_4096
time: [2.2513 ms 2.2909 ms 2.3374 ms]
change: [-2.5853% -0.2684% +2.1474%] (p = 0.82 >
0.05)
No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe
character_length_StringViewArray_ascii_str_len_4096
time: [908.83 µs 918.63 µs 930.69 µs]
change: [+0.2174% +0.9753% +1.8034%] (p = 0.02 <
0.05)
Change within noise threshold.
Found 14 outliers among 100 measurements (14.00%)
2 (2.00%) high mild
12 (12.00%) high severe
character_length_StringViewArray_utf8_str_len_4096
time: [2.2551 ms 2.2682 ms 2.2819 ms]
change: [+0.0452% +0.7871% +1.5412%] (p = 0.05 <
0.05)
Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
