Jefffrey commented on code in PR #10: URL: https://github.com/apache/datafusion-testing/pull/10#discussion_r2272145585
########## data/sqlite/random/aggregates/slt_good_100.slt: ########## @@ -26465,11 +26468,14 @@ SELECT DISTINCT - col2 AS col2, CAST ( - col0 AS INTEGER ) + + 58 FROM tab0 -99 -39 -# Datafusion - Datafusion expected results: -# Datafusion - Expected - 32 -# Datafusion - Expected - NULL -query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations are not available +# Datafusion - Types were automatically converted from: +# Datafusion - [Expected] I[I] +# Datafusion - [Actual ] I[R] +query IR rowsort label-4361 SELECT DISTINCT + 32 AS col0, CAST ( + CAST ( NULL AS INTEGER ) AS INTEGER ) + - MIN ( ALL 59 ) * - AVG ( DISTINCT 64 ) AS col2 FROM tab2 +---- +32 +NULL Review Comment: Silly question, but are there results here from two columns of one row? Instead of two distinct rows? I thought SLT files specified expected output in a tabular like format, instead of flattening the rows & columns together? e.g. https://github.com/apache/datafusion/blob/1e3152ee1eb65e44bb1a4b91fa857d845be9659e/datafusion/sqllogictest/test_files/json.slt#L32-L35 ########## data/sqlite/random/expr/slt_good_95.slt: ########## @@ -22676,10 +22691,16 @@ SELECT ALL 11 + NULLIF ( - - 79, 13 / + 44 * + + COUNT ( * ) ) AS col2 ---- 90 -# Datafusion - Datafusion expected results: -# Datafusion - Expected - 35 -query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations are not available +# Datafusion - Data was automatically updated based on comparison db results +# Datafusion - Previous results: +# Datafusion - 35 +# Datafusion - Types were automatically converted from: +# Datafusion - [Expected] [I] +# Datafusion - [Actual ] [R] +query R rowsort label-4329 SELECT + NULLIF ( 95, - + 92 ) + + 14 + - MIN ( DISTINCT 74 ) + 24 / - CASE 95 WHEN + + 29 THEN + COALESCE ( - + 36, + + AVG ( DISTINCT + 29 ) * 82 ) * CAST ( - 78 AS INTEGER ) + MAX ( ALL - 41 ) + 39 * CAST ( NULL AS INTEGER ) * - - CASE + CASE ( + 24 ) WHEN - - 46 THEN NULL WHEN - CAST ( - - 99 AS INTEGER ) THEN + - 75 + + 49 + - 48 + - 64 END WHEN + 76 - + + 33 / + 13 + - + 70 THEN - 35 / 88 ELSE NULL END * - 27 * - - 60 WHEN + - 47 THEN NULL ELSE - 80 END * - + 96 AS col0 +---- +6.2 Review Comment: This is interesting, it has the wrong result ########## data/sqlite/random/expr/slt_good_63.slt: ########## @@ -13316,11 +13331,18 @@ SELECT ALL + COUNT ( * ) / 79 ---- 0 -# Datafusion - Datafusion expected results: -# Datafusion - Expected - 50 -# Datafusion - Expected - -12 -query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations are not available +# Datafusion - Data was automatically updated based on comparison db results +# Datafusion - Previous results: +# Datafusion - 50 +# Datafusion - -12 +# Datafusion - Types were automatically converted from: +# Datafusion - [Expected] I[I] +# Datafusion - [Actual ] I[R] +query IR rowsort label-2529 SELECT ALL + 50 AS col2, + 62 / - - COALESCE ( - + 5, - - COUNT ( * ) / - + AVG ( DISTINCT 81 ) + - 24 - - CAST ( NULL AS INTEGER ) + COUNT ( 94 ) * - 3 * - 4 * + 42 + + 82 + - ( + - 59 ) ) AS col0 +---- +50 +-12.4 Review Comment: Something to check here too ########## data/sqlite/random/aggregates/slt_good_119.slt: ########## @@ -670,13 +670,10 @@ SELECT ALL * FROM tab1 WHERE NOT + - CAST ( NULL AS INTEGER ) + - col2 - + col0 ---- 9 values hashing to c6c0a4111b36d04dbc811a11e4d54cad -# Datafusion - Types were automatically converted from: -# Datafusion - [Expected] [I] -# Datafusion - [Actual ] [R] -query R rowsort label-107 +# Datafusion - Datafusion expected results: +# Datafusion - Expected - NULL +query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations are not available Review Comment: So was this supposed to be fixed to output null again, instead of erroring? ########## data/sqlite/random/expr/slt_good_79.slt: ########## @@ -42352,10 +42361,16 @@ SELECT ALL 34 * - 82 / - ( - - 41 ) AS col0 ---- 68 -# Datafusion - Datafusion expected results: -# Datafusion - Expected - 0 -query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations are not available +# Datafusion - Data was automatically updated based on comparison db results +# Datafusion - Previous results: +# Datafusion - 0 +# Datafusion - Types were automatically converted from: +# Datafusion - [Expected] [I] +# Datafusion - [Actual ] [R] +query R rowsort label-8087 SELECT + - 56 / - COALESCE ( 66, + 49 * - ( - AVG ( DISTINCT - NULLIF ( - - 92, 91 + - - CAST ( + 60 AS INTEGER ) ) ) ) + CAST ( NULL AS INTEGER ) ) AS col0 +---- +0.848484848485 Review Comment: Here ########## data/sqlite/random/expr/slt_good_56.slt: ########## @@ -10795,10 +10816,16 @@ SELECT ALL - CASE 56 WHEN - 16 + + COUNT ( * ) * + - COUNT ( * ) * - 78 * - 24 T ---- NULL -# Datafusion - Datafusion expected results: -# Datafusion - Expected - -90 -query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations are not available +# Datafusion - Data was automatically updated based on comparison db results +# Datafusion - Previous results: +# Datafusion - -90 +# Datafusion - Types were automatically converted from: +# Datafusion - [Expected] [I] +# Datafusion - [Actual ] [R] +query R rowsort label-2056 SELECT + COALESCE ( + COALESCE ( COUNT ( * ), - 93 ), + - 30 / - 73 + + CAST ( + - 13 AS INTEGER ), ( CASE 4 WHEN + ( + 16 ) THEN NULL WHEN 20 - - + 12 THEN 48 WHEN - + 27 THEN NULL END ) / + 90 * + 6 + 93 * AVG ( DISTINCT + - 50 ) * - 51 ) / - 87 + - ( 85 ) + - 5 +---- +-90.011494252874 Review Comment: Here too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
