findepi commented on code in PR #10: URL: https://github.com/apache/datafusion-testing/pull/10#discussion_r2272505682
########## data/sqlite/random/aggregates/slt_good_100.slt: ########## @@ -26465,11 +26468,14 @@ SELECT DISTINCT - col2 AS col2, CAST ( - col0 AS INTEGER ) + + 58 FROM tab0 -99 -39 -# Datafusion - Datafusion expected results: -# Datafusion - Expected - 32 -# Datafusion - Expected - NULL -query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations are not available +# Datafusion - Types were automatically converted from: +# Datafusion - [Expected] I[I] +# Datafusion - [Actual ] I[R] +query IR rowsort label-4361 SELECT DISTINCT + 32 AS col0, CAST ( + CAST ( NULL AS INTEGER ) AS INTEGER ) + - MIN ( ALL 59 ) * - AVG ( DISTINCT 64 ) AS col2 FROM tab2 +---- +32 +NULL Review Comment: > instead of flattening the rows & columns together SLT seems to have option for that: `SortMode::ValueSort. But here we declare `rowsort` to be used. I tried to run the updade script locally and got confused by this as well -- https://github.com/apache/datafusion/issues/17120#issuecomment-3176139862 @Omega359 @alamb is there some non-default configuration applied to SLT here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
