pepijnve commented on code in PR #17131:
URL: https://github.com/apache/datafusion/pull/17131#discussion_r2273095321
##########
datafusion/functions/src/string/ascii.rs:
##########
@@ -30,7 +30,7 @@ use std::sync::Arc;
#[user_doc(
doc_section(label = "String Functions"),
- description = "Returns the Unicode character code of the first character
in a string.",
+ description = "Returns the first Unicode scalar value of a string.",
Review Comment:
Fair comment, perhaps I'm trying to be too precise. This method really does
get the first Unicode code point (minus surrogates, so scalar value) of the
first grapheme cluster. That's a Rust `char`, but not necessarily what you
intuitively think of as a character.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
