Jefffrey commented on code in PR #17131:
URL: https://github.com/apache/datafusion/pull/17131#discussion_r2273120657


##########
datafusion/sqllogictest/test_files/expr.slt:
##########


Review Comment:
   Is there a NUL character in the file now?
   
   This is how it looks on GitHub to me:
   
   <img width="824" height="152" alt="image" 
src="https://github.com/user-attachments/assets/7875ea32-10f2-49d7-87ad-76b8691dd9ee";
 />
   
   Note how it seems to find an invisible `chr` string, compared to without 
search:
   
   <img width="820" height="144" alt="image" 
src="https://github.com/user-attachments/assets/992ce5b9-29b8-4a2c-a609-051ec5372073";
 />
   
   If there is a NUL character maybe that is causing issues with how GitHub 
parses the file? Should we print `\0` like DuckDB does?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to