adriangb commented on PR #16433: URL: https://github.com/apache/datafusion/pull/16433#issuecomment-3184612966
I tried some stuff. Still not an obvious improvement: ``` /bench.sh compare main topk-filters Comparing main and topk-filters -------------------- Benchmark run_topk_tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ topk-filters ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 12.46 ms │ 10.55 ms │ +1.18x faster │ │ Q2 │ 14.02 ms │ 12.06 ms │ +1.16x faster │ │ Q3 │ 29.39 ms │ 30.10 ms │ no change │ │ Q4 │ 13.74 ms │ 12.79 ms │ +1.07x faster │ │ Q5 │ 7.44 ms │ 7.09 ms │ no change │ │ Q6 │ 15.87 ms │ 13.79 ms │ +1.15x faster │ │ Q7 │ 37.22 ms │ 44.24 ms │ 1.19x slower │ │ Q8 │ 27.51 ms │ 25.17 ms │ +1.09x faster │ │ Q9 │ 33.04 ms │ 31.28 ms │ +1.06x faster │ │ Q10 │ 55.26 ms │ 58.96 ms │ 1.07x slower │ │ Q11 │ 28.74 ms │ 29.75 ms │ no change │ └──────────────┴──────────┴──────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩ │ Total Time (main) │ 274.68ms │ │ Total Time (topk-filters) │ 275.79ms │ │ Average Time (main) │ 24.97ms │ │ Average Time (topk-filters) │ 25.07ms │ │ Queries Faster │ 6 │ │ Queries Slower │ 2 │ │ Queries with No Change │ 3 │ │ Queries with Failure │ 0 │ └─────────────────────────────┴──────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
