adriangb commented on PR #16433: URL: https://github.com/apache/datafusion/pull/16433#issuecomment-3193850159
Okay I've re-run after 310100b and am now seeing only improvements across the board. @Dandandan I've requested another review from you since I think this may be in a good place now. ``` Comparing main and topk-filters -------------------- Benchmark run_topk_tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ topk-filters ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 11.22 ms │ 9.41 ms │ +1.19x faster │ │ Q2 │ 13.90 ms │ 11.78 ms │ +1.18x faster │ │ Q3 │ 33.71 ms │ 29.55 ms │ +1.14x faster │ │ Q4 │ 13.81 ms │ 12.89 ms │ +1.07x faster │ │ Q5 │ 8.65 ms │ 7.04 ms │ +1.23x faster │ │ Q6 │ 14.67 ms │ 14.65 ms │ no change │ │ Q7 │ 45.67 ms │ 38.13 ms │ +1.20x faster │ │ Q8 │ 27.73 ms │ 25.61 ms │ +1.08x faster │ │ Q9 │ 35.25 ms │ 34.09 ms │ no change │ │ Q10 │ 56.27 ms │ 52.07 ms │ +1.08x faster │ │ Q11 │ 32.06 ms │ 30.42 ms │ +1.05x faster │ └──────────────┴──────────┴──────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩ │ Total Time (main) │ 292.93ms │ │ Total Time (topk-filters) │ 265.65ms │ │ Average Time (main) │ 26.63ms │ │ Average Time (topk-filters) │ 24.15ms │ │ Queries Faster │ 9 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 2 │ │ Queries with Failure │ 0 │ └─────────────────────────────┴──────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
