alamb commented on code in PR #17175:
URL: https://github.com/apache/datafusion/pull/17175#discussion_r2276256424


##########
datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt:
##########
@@ -536,7 +536,7 @@ COPY (
         '2023-10-01 00:00:00'::timestamptz AS start_timestamp,
         'prod' as deployment_environment
 )
-TO 'data/1.parquet';
+TO 'test_files/scratch/parquet_filter_pushdown/data/1.parquet';

Review Comment:
   It seems like the test was previously writing data to 
`datafusion/sqllogictest/data/1.parquet` and 
`datafusion/sqllogictest/data/2.parquet` which are also checked in
   
   This means that when the new files are written (with a new datafusion 
version string) they are different which failed the "working directory clean" 
check. Here is an example: 
https://github.com/apache/datafusion/actions/runs/16942532196/job/48015583433?pr=17175
   
   <img width="951" height="278" alt="Screenshot 2025-08-14 at 6 39 19 AM" 
src="https://github.com/user-attachments/assets/62261cdf-9286-4e7c-9d21-bd6c84400198";
 />
   
   I changed this test to properly use the scratch location instead
   
   (I will port this to main as well once we release 49.0.1)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to