alamb commented on code in PR #17175: URL: https://github.com/apache/datafusion/pull/17175#discussion_r2276278938
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -4240,23 +4240,23 @@ set datafusion.execution.target_partitions = 1; # Note we use csv as MemoryExec does not support limit push down (so doesn't manifest # bugs if limits are improperly pushed down) query I -COPY (values (1), (2), (3), (4), (5)) TO 'test_files/scratch/limit/t1.csv' +COPY (values (1), (2), (3), (4), (5)) TO 'test_files/scratch/joins/t1.csv' Review Comment: This test was failing on the branch. Here is an example https://github.com/apache/datafusion/actions/runs/16948253306/job/48035037022?pr=17175 <img width="1434" height="171" alt="Screenshot 2025-08-14 at 6 50 01 AM" src="https://github.com/user-attachments/assets/7080ae8d-767c-4a91-8e89-173dc902e9db" /> The issue is that it is using the wrong scratch space. This was fixed by @2010YOUY01 on main in - https://github.com/apache/datafusion/pull/16880 - (and a check to prevent it from happening again added in https://github.com/apache/datafusion/pull/17017) I backported the fix to this PR to get a clean CI run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org