alamb commented on code in PR #17183:
URL: https://github.com/apache/datafusion/pull/17183#discussion_r2276319136
##########
.asf.yaml:
##########
@@ -50,8 +50,38 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ strict: true # Require branches to be up to date before merging
+ contexts:
+ - "Check License Header"
Review Comment:
I worry about this list
1. It may get out of date if people add a new check
2. I worry this might break the repo entirely (if we for example, change the
name of one of these files)
3. What happens to workflows that don't run all these checks (like
documentation, for example)
I am particularly worried about the note in
https://github.com/apache/infrastructure-asfyaml/blob/main/README.md#branch-protection
> A typo in these settings for the default branch will prevent you from
modifying the .asf.yaml file itself.
<img width="1022" height="151" alt="Screenshot 2025-08-14 at 7 07 35 AM"
src="https://github.com/user-attachments/assets/abbfcb80-6b22-462e-a6ce-5572cd7a2da3";
/>
I think it is better to potentially have main fail some CI checks that we
can fix rather than effectively locking ourselves out of committing anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
