blaginin commented on code in PR #17183:
URL: https://github.com/apache/datafusion/pull/17183#discussion_r2286225625
##########
.asf.yaml:
##########
@@ -50,8 +50,38 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ strict: true # Require branches to be up to date before merging
+ contexts:
+ - "Check License Header"
Review Comment:
That's very fair! The reason I did this is because MQ only waits for the
required stages to pass.
I'm less worried about people forgetting to add new checks here (since it
shows if checks are required / non-required on every PR and is easy to spot).
What worries me more is that it's very easy to rename a stage in `.github` but
forget to update it here.
I'm thinking we can solve this by adding a "check to check all checks" 😁 - a
new github action that verifies `.asf.yaml` includes all `.github` actions.
Happy to do that if we manage to enable merge queues.
Also, while we're evaluating whether queues are right for us, I think it'd
be good to let core maintainers bypass checks just in case, so we don't lock
ourselves completely. GitHub supports that:
<img width="926" height="411" alt="Zen Browser 2025-08-19 21 11 10"
src="https://github.com/user-attachments/assets/aad9f040-6c21-4742-8257-89dacb3e0456";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
