andygrove commented on code in PR #2155:
URL: https://github.com/apache/datafusion-comet/pull/2155#discussion_r2277229709
##########
native/core/src/execution/planner.rs:
##########
@@ -2611,8 +2614,10 @@ impl From<ExpressionError> for DataFusionError {
/// data corruption from reusing the input batch.
fn can_reuse_input_batch(op: &Arc<dyn ExecutionPlan>) -> bool {
if op.as_any().is::<ScanExec>() {
- // JVM side can return arrow buffers to the pool
- // Also, native_comet scan reuses mutable buffers
+ // native_comet and native_iceberg_compat scan reuse mutable buffers
+ // so we need to make copies of the batches
+ // for now, we also copy even if the source is not a Parquet scan, but
+ // we will optimize this later
Review Comment:
unrelated, but the old comment was inaccurate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
