andygrove commented on PR #2155:
URL:
https://github.com/apache/datafusion-comet/pull/2155#issuecomment-3189494802
> oh so do we use SMJ by default?
>
> ```
> val COMET_REPLACE_SMJ: ConfigEntry[Boolean] =
> conf(s"$COMET_EXEC_CONFIG_PREFIX.replaceSortMergeJoin")
> .doc("Experimental feature to force Spark to replace SortMergeJoin
with ShuffledHashJoin " +
> s"for improved performance. This feature is not stable yet.
$TUNING_GUIDE.")
> .booleanConf
> .createWithDefault(false)
> ```
Yes, we don't have spill support in hash joins yet, so they can easily OOM.
For the published benchmark results for TPC-H, I enable hash join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
