andygrove commented on code in PR #2159:
URL: https://github.com/apache/datafusion-comet/pull/2159#discussion_r2279000583
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -543,20 +527,7 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
if (nativeOrColumnarShuffle.isDefined) {
nativeOrColumnarShuffle.get
} else {
- val isShuffleEnabled = isCometShuffleEnabled(conf)
- val reason = getCometShuffleNotEnabledReason(conf).getOrElse("no
reason available")
- val msg1 = createMessage(!isShuffleEnabled, s"Comet shuffle is not
enabled: $reason")
- val columnarShuffleEnabled = isCometJVMShuffleMode(conf)
- val msg2 = createMessage(
- isShuffleEnabled && !columnarShuffleEnabled &&
!nativeShuffleSupported(s)._1,
- "Native shuffle: " +
- s"${nativeShuffleSupported(s)._2}")
- val typeInfo = columnarShuffleSupported(s)._2
- val msg3 = createMessage(
- isShuffleEnabled && columnarShuffleEnabled &&
!columnarShuffleSupported(s)._1,
- "JVM shuffle: " +
- s"$typeInfo")
- withInfo(s, Seq(msg1, msg2, msg3).flatten.mkString(","))
Review Comment:
This code is no longer needed because we already tagges the plan with
fallback reasons when calling `nativeShuffleSupported` and
`columnarShuffleSupported`
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -543,20 +527,7 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
if (nativeOrColumnarShuffle.isDefined) {
nativeOrColumnarShuffle.get
} else {
- val isShuffleEnabled = isCometShuffleEnabled(conf)
- val reason = getCometShuffleNotEnabledReason(conf).getOrElse("no
reason available")
- val msg1 = createMessage(!isShuffleEnabled, s"Comet shuffle is not
enabled: $reason")
- val columnarShuffleEnabled = isCometJVMShuffleMode(conf)
- val msg2 = createMessage(
- isShuffleEnabled && !columnarShuffleEnabled &&
!nativeShuffleSupported(s)._1,
- "Native shuffle: " +
- s"${nativeShuffleSupported(s)._2}")
- val typeInfo = columnarShuffleSupported(s)._2
- val msg3 = createMessage(
- isShuffleEnabled && columnarShuffleEnabled &&
!columnarShuffleSupported(s)._1,
- "JVM shuffle: " +
- s"$typeInfo")
- withInfo(s, Seq(msg1, msg2, msg3).flatten.mkString(","))
Review Comment:
This code is no longer needed because we already tagged the plan with
fallback reasons when calling `nativeShuffleSupported` and
`columnarShuffleSupported`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
