comphead commented on code in PR #2159:
URL: https://github.com/apache/datafusion-comet/pull/2159#discussion_r2279876687
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -794,11 +779,24 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
false
}
+ if (!isCometShuffleEnabledWithInfo(s)) {
+ return false
+ }
+
+ if (!isCometNativeShuffleMode(s.conf)) {
+ withInfo(s, "Comet native shuffle not enabled")
+ return false
+ }
+
+ if (!isCometPlan(s.child)) {
+ withInfo(s, "Child is not native")
Review Comment:
```suggestion
withInfo(s, "Child {s.child.getClass.getName} is not native")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
