Jefffrey commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2285140974
##########
datafusion/sql/src/expr/substring.rs:
##########
@@ -77,8 +78,16 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
}
}
- not_impl_err!(
- "Substring not supported by UserDefinedExtensionPlanners:
{substring_args:?}"
- )
+ let fun = self
Review Comment:
I'm not familiar with that API, though it seems to be used above already?
https://github.com/apache/datafusion/blob/c22d64b3f0596a9829eea60d7790729ddeec3819/datafusion/sql/src/expr/substring.rs#L72-L79
So this code here (that hardcodes the `"substr"` string) is more of a
fallback I guess? Might need some help understanding this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
