Jefffrey commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2286808615
##########
datafusion/sql/src/expr/substring.rs:
##########
@@ -77,8 +78,16 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
}
}
- not_impl_err!(
- "Substring not supported by UserDefinedExtensionPlanners:
{substring_args:?}"
- )
+ let fun = self
Review Comment:
This makes sense to me, yeah. Would be confusing to fall back to a user
defined `substr` indeed 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
