adriangb commented on code in PR #16433:
URL: https://github.com/apache/datafusion/pull/16433#discussion_r2286448656
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -137,7 +139,7 @@ impl DynamicFilterPhysicalExpr {
Self {
children,
remapped_children: None, // Initially no remapped children
- inner: Arc::new(RwLock::new(Inner::new(inner))),
+ inner: Arc::new(ArcSwap::from_pointee(Inner::new(inner))),
Review Comment:
> it seems to have plenty of dependencies
https://crates.io/crates/arc-swap/1.7.1/dependencies
I see no required dependencies. Only dev deps.
> And its last release was over a year ago:
https://crates.io/crates/arc-swap/1.7.1
Personally I don't see any issue with this: I'd look at the ratio of open
issues / obvious bugs vs. releases. If there's no features to add and no major
bugs having few releases can be a good thing 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
