alamb commented on code in PR #16433:
URL: https://github.com/apache/datafusion/pull/16433#discussion_r2286474109


##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -137,7 +139,7 @@ impl DynamicFilterPhysicalExpr {
         Self {
             children,
             remapped_children: None, // Initially no remapped children
-            inner: Arc::new(RwLock::new(Inner::new(inner))),
+            inner: Arc::new(ArcSwap::from_pointee(Inner::new(inner))),

Review Comment:
   I maybe have been burned one too many times by random maintainers on the 
internet deciding to disappear, etc and I am trying to keep the dependency load 
down for DataFusion. I realize I may be over sensitive on this topic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to