2010YOUY01 commented on PR #16660: URL: https://github.com/apache/datafusion/pull/16660#issuecomment-3204124621
Awesome! It's on my list. To ensure the correctness, I recommend to write a POC planner first to let this operator be able to run through SQL interface, and ensure extended test passes. (planner part is expected to be made in a separate PR) ``` INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictests ``` I think the strongest test for join edge cases so far is the sqlite test suite -- From my recent PR, it passed all DF test+fuzz test, but the sqlite test suite found 3 additional bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
