ding-young commented on PR #17244: URL: https://github.com/apache/datafusion/pull/17244#issuecomment-3206405172
Thank you for the fix! I actually encountered the same issue, and really glad to see this PR. BTW, have you considered directly creating a stream that sorts a batch and slices it into multiple `batch_size` batches, instead of wrapping it with `BatchSplitStream`? That way, we could avoid generating dummy metrics and have more direct control over memory reservation. Something like this: https://gist.github.com/ding-young/25ce38cd6449a3c35bc0df430e6a2eab I'm just sharing the idea since you mentioned the issue with `BatchSplitStream`, and I think this pr's approach is also nice. :smile: Plus, after this PR gets merged, I'll be glad to hear your review on https://github.com/apache/datafusion/pull/17163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
