rluvaton commented on PR #17244:
URL: https://github.com/apache/datafusion/pull/17244#issuecomment-3206675141
> Thank you for the fix! I actually encountered the same issue, and really
glad to see this PR.
>
> BTW, have you considered directly creating a stream that sorts a batch and
slices it into multiple `batch_size` batches, instead of wrapping it with
`BatchSplitStream`? That way, we could avoid generating dummy metrics and have
more direct control over memory reservation.
>
Yes but decided not to for:
1. simplicity
2. it should be batch split stream responsibility as datafusion take on
memory is whoever hold the data should account for it
>
https://github.com/apache/datafusion/blob/3a312a9976432e705f69ab6b6be2f49889eeb89b/datafusion/execution/src/memory_pool/mod.rs#L59-L62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
