alamb commented on PR #17195: URL: https://github.com/apache/datafusion/pull/17195#issuecomment-3207027997
@mbutrovich -- thank you for this PR. I still can't help but feel there is a mismatch between what this PR is doing (trying expand the types of string arguments this function supports) and what you are actually seeing in Comet. Can you explain what is happening in comet? For example, is regexp_replace being called with `regexp_replace(UTF8View, Utf8View, Utf8View)` I ask because a mismatch between the actual argument types, and the types a function accepts can be fixed in at least 2 ways: 1. Expand the types a function supports (this PR) 2. Cast the arguments to some combination that the function supports (via coercion). Typically coercion is done in the LogicalPlan, and I know that Comet does not use LogicalPlans. However, @adriangb and @kosiew have been working on a version of this for `PhysicalExprs`, in the [PhysicalExprAdapter](https://docs.rs/datafusion/latest/datafusion/physical_expr/schema_rewriter/trait.PhysicalExprAdapter.html) I also reviewed the documentation on types and type signatures and I think there is some ambiguity about what a function "supporting argument types" means. I will make a PR to improve the documentation in this area -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
