alamb commented on code in PR #17197:
URL: https://github.com/apache/datafusion/pull/17197#discussion_r2288961274
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -267,7 +267,7 @@ async fn
test_dynamic_filter_pushdown_through_hash_join_with_topk() {
format_plan_for_test(&plan),
@r"
- SortExec: TopK(fetch=2), expr=[e@4 ASC], preserve_partitioning=[false],
filter=[e@4 IS NULL OR e@4 < bb]
- - HashJoinExec: mode=Partitioned, join_type=Inner, on=[(a@0, d@0)],
filter=[d@0 >= aa AND d@0 <= ab]
+ - HashJoinExec: mode=Partitioned, join_type=Inner, on=[(a@0, d@0)]
Review Comment:
To other reviewers, the filters are still pushed down to the DataSourceExec
(it just isn't reflected on the HashJoinExec itself0
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -98,6 +98,262 @@ use parking_lot::Mutex;
const HASH_JOIN_SEED: RandomState =
RandomState::with_seeds('J' as u64, 'O' as u64, 'I' as u64, 'N' as u64);
+/// Represents the minimum and maximum values for a specific column.
Review Comment:
I personally find this much easier to understand -- thank you @adriangb
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -706,15 +975,7 @@ impl DisplayAs for HashJoinExec {
.map(|(c1, c2)| format!("({c1}, {c2})"))
.collect::<Vec<String>>()
.join(", ");
- let dynamic_filter_display = match
self.dynamic_filter.as_ref() {
- Some(dynamic_filter) => match dynamic_filter.current() {
- Ok(current) if current != lit(true) => {
- format!(", filter=[{current}]")
- }
- _ => "".to_string(),
- },
- None => "".to_string(),
- };
+ let dynamic_filter_display = "".to_string();
Review Comment:
this looks like it could just be removed as it no longer shows anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
