adriangb commented on PR #17197: URL: https://github.com/apache/datafusion/pull/17197#issuecomment-3207906905
Here's results from my local machine: ``` Comparing main and fix-hash-join-partitioned -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ fix-hash-join-partitioned ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.93 ms │ 0.94 ms │ no change │ │ QQuery 1 │ 11.23 ms │ 10.93 ms │ no change │ │ QQuery 2 │ 35.08 ms │ 34.38 ms │ no change │ │ QQuery 3 │ 34.85 ms │ 34.81 ms │ no change │ │ QQuery 4 │ 274.53 ms │ 270.18 ms │ no change │ │ QQuery 5 │ 350.38 ms │ 349.15 ms │ no change │ │ QQuery 6 │ 0.91 ms │ 0.82 ms │ +1.11x faster │ │ QQuery 7 │ 13.06 ms │ 12.46 ms │ no change │ │ QQuery 8 │ 335.96 ms │ 322.05 ms │ no change │ │ QQuery 9 │ 477.25 ms │ 473.04 ms │ no change │ │ QQuery 10 │ 85.16 ms │ 85.73 ms │ no change │ │ QQuery 11 │ 95.87 ms │ 98.19 ms │ no change │ │ QQuery 12 │ 324.21 ms │ 323.77 ms │ no change │ │ QQuery 13 │ 468.87 ms │ 477.11 ms │ no change │ │ QQuery 14 │ 306.01 ms │ 301.96 ms │ no change │ │ QQuery 15 │ 307.36 ms │ 303.33 ms │ no change │ │ QQuery 16 │ 735.54 ms │ 732.70 ms │ no change │ │ QQuery 17 │ 726.69 ms │ 707.14 ms │ no change │ │ QQuery 18 │ 1768.84 ms │ 1527.52 ms │ +1.16x faster │ │ QQuery 19 │ 28.60 ms │ 26.75 ms │ +1.07x faster │ │ QQuery 20 │ 735.84 ms │ 672.82 ms │ +1.09x faster │ │ QQuery 21 │ 805.33 ms │ 748.53 ms │ +1.08x faster │ │ QQuery 22 │ 1265.32 ms │ 1168.32 ms │ +1.08x faster │ │ QQuery 23 │ 4507.52 ms │ 3785.36 ms │ +1.19x faster │ │ QQuery 24 │ 134.22 ms │ 99.76 ms │ +1.35x faster │ │ QQuery 25 │ 168.16 ms │ 148.06 ms │ +1.14x faster │ │ QQuery 26 │ 118.92 ms │ 98.44 ms │ +1.21x faster │ │ QQuery 27 │ 1131.20 ms │ 836.35 ms │ +1.35x faster │ │ QQuery 28 │ 6888.21 ms │ 6774.13 ms │ no change │ │ QQuery 29 │ 357.40 ms │ 324.16 ms │ +1.10x faster │ │ QQuery 30 │ 317.28 ms │ 302.51 ms │ no change │ │ QQuery 31 │ 316.73 ms │ 313.78 ms │ no change │ │ QQuery 32 │ 1575.35 ms │ 1695.26 ms │ 1.08x slower │ │ QQuery 33 │ 1859.20 ms │ 1551.85 ms │ +1.20x faster │ │ QQuery 34 │ 1839.58 ms │ 1759.96 ms │ no change │ │ QQuery 35 │ 498.48 ms │ 488.93 ms │ no change │ │ QQuery 36 │ 62.53 ms │ 62.01 ms │ no change │ │ QQuery 37 │ 24.15 ms │ 24.41 ms │ no change │ │ QQuery 38 │ 61.68 ms │ 61.55 ms │ no change │ │ QQuery 39 │ 103.08 ms │ 103.62 ms │ no change │ │ QQuery 40 │ 18.36 ms │ 16.91 ms │ +1.09x faster │ │ QQuery 41 │ 16.02 ms │ 16.60 ms │ no change │ │ QQuery 42 │ 13.88 ms │ 13.36 ms │ no change │ └──────────────┴────────────┴───────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main) │ 29199.78ms │ │ Total Time (fix-hash-join-partitioned) │ 27159.63ms │ │ Average Time (main) │ 679.06ms │ │ Average Time (fix-hash-join-partitioned) │ 631.62ms │ │ Queries Faster │ 14 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 28 │ │ Queries with Failure │ 0 │ └──────────────────────────────────────────┴────────────┘ -------------------- Benchmark h2o_join.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ fix-hash-join-partitioned ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 0.82 ms │ 0.66 ms │ +1.25x faster │ │ QQuery 2 │ 26.58 ms │ 26.48 ms │ no change │ │ QQuery 3 │ 25.73 ms │ 25.71 ms │ no change │ │ QQuery 4 │ 21.92 ms │ 22.10 ms │ no change │ │ QQuery 5 │ 6678.28 ms │ 6568.61 ms │ no change │ └──────────────┴────────────┴───────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 6753.34ms │ │ Total Time (fix-hash-join-partitioned) │ 6643.54ms │ │ Average Time (main) │ 1350.67ms │ │ Average Time (fix-hash-join-partitioned) │ 1328.71ms │ │ Queries Faster │ 1 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 4 │ │ Queries with Failure │ 0 │ └──────────────────────────────────────────┴───────────┘ -------------------- Benchmark tpch_sf10.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ fix-hash-join-partitioned ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 469.22 ms │ 451.54 ms │ no change │ │ QQuery 2 │ 93.19 ms │ 89.56 ms │ no change │ │ QQuery 3 │ 245.37 ms │ 245.78 ms │ no change │ │ QQuery 4 │ 202.82 ms │ 193.28 ms │ no change │ │ QQuery 5 │ 348.62 ms │ 339.03 ms │ no change │ │ QQuery 6 │ 127.61 ms │ 126.03 ms │ no change │ │ QQuery 7 │ 502.29 ms │ 483.22 ms │ no change │ │ QQuery 8 │ 417.75 ms │ 378.14 ms │ +1.10x faster │ │ QQuery 9 │ 634.01 ms │ 562.24 ms │ +1.13x faster │ │ QQuery 10 │ 331.93 ms │ 311.05 ms │ +1.07x faster │ │ QQuery 11 │ 75.21 ms │ 67.87 ms │ +1.11x faster │ │ QQuery 12 │ 197.60 ms │ 184.62 ms │ +1.07x faster │ │ QQuery 13 │ 356.67 ms │ 335.05 ms │ +1.06x faster │ │ QQuery 14 │ 178.51 ms │ 167.70 ms │ +1.06x faster │ │ QQuery 15 │ 257.11 ms │ 232.88 ms │ +1.10x faster │ │ QQuery 16 │ 65.33 ms │ 58.28 ms │ +1.12x faster │ │ QQuery 17 │ 650.07 ms │ 617.45 ms │ +1.05x faster │ │ QQuery 18 │ 985.80 ms │ 885.19 ms │ +1.11x faster │ │ QQuery 19 │ 284.72 ms │ 266.58 ms │ +1.07x faster │ │ QQuery 20 │ 233.45 ms │ 223.05 ms │ no change │ │ QQuery 21 │ 699.61 ms │ 652.03 ms │ +1.07x faster │ │ QQuery 22 │ 83.26 ms │ 80.68 ms │ no change │ └──────────────┴───────────┴───────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 7440.16ms │ │ Total Time (fix-hash-join-partitioned) │ 6951.27ms │ │ Average Time (main) │ 338.19ms │ │ Average Time (fix-hash-join-partitioned) │ 315.97ms │ │ Queries Faster │ 13 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 9 │ │ Queries with Failure │ 0 │ └──────────────────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org