SparkApplicationMaster commented on PR #17179: URL: https://github.com/apache/datafusion/pull/17179#issuecomment-3212312955
@Jefffrey thanks for review! in spark, bitmap functions are isolated in their own `bitmap` file and function group https://github.com/apache/spark/blob/8530444e25b83971da4314c608aa7d763adeceb3/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L842 https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitmapExpressions.scala#L250 so maybe it's better to create this `bitmap` module in spark crate? I'll modify the PR to implement this, so next bitmap functions can go where they belong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
