vegarsti commented on PR #16985: URL: https://github.com/apache/datafusion/pull/16985#issuecomment-3214725822
> Thank you for this contribution @vegarsti > > > > I am sorry for the delayed review -- I am always trying to encourage others to review PRs, but indeed I often function as the reviewer of last resort. Anything you can do to help (like help review PRs yourself) would be most appreciated! > > > > This is definitely the right direction, but when I did some testing of this PR some of the behavior didn't make sense to me > > > > Could you look at the test I provided, as well as add additional cases: > > 1. That unnest a struct (the one I provided unnests a list) > > 2. has multiple list/structs unnested (as the code seems to handle such a case) Thank you so much for the detailed and gracious review. Thanks for catching the weird behavior, I will address this. And I am happy to start reviewing PRs! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
