alamb commented on PR #17232: URL: https://github.com/apache/datafusion/pull/17232#issuecomment-3216614135
> I believe this sequence of tests successfully exercises both the creation of hive partitioned tables, as well as the expected outcome when reading that data. > > I'm happy to move this test, and the associated test setup, to a new file and/or augment it with the SQL commands you've laid out above. Given the above explanation, let me know if you'd still prefer to proceed with a new test file or if what's already there is sufficient. I think give we are about to add non trivial new functionality (even if the code is not new), we should make the tests I suggested > I think it's prudent to note that the changes here only effect the ListingTableFactory and low level ListingTable users wouldn't experience any change. Is an execution option stil the right place for the configuration setting? Yes, I think so (unless you can find another location for Listingtable settings -- maybe we should make a new category 🤔 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
