jonathanc-n commented on PR #17304: URL: https://github.com/apache/datafusion/pull/17304#issuecomment-3217130658
@2010YOUY01 I was thinking that `stream.rs` is quite large here. Do you think functions like `compare_join_array`, `is_join_arrays_equal`, etc. should be put into `utils`. I was hesitant since they are only used in SMJ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org