coderfender commented on PR #2136: URL: https://github.com/apache/datafusion-comet/pull/2136#issuecomment-3221124473
Summary of changes Native Side : 1. Implemented ANSI mode to throw exceptions for arithmetic operations 2. Changes to planner.rs to support eval mode all the way to scalar function UDF 3. Update checked_arithmetic.rs to return NULL or throw Spark like exception depending on overflow. 4. Add support to Float data types (in addition to int data types) Scala side: 1. Disable replacing 0's with NULLs when ANSI mode is enabled for arithmetic operation 2. Disable comet coalesce when ANSI mode is enabled. This is because coalesce in comet throws an exception while spark suppresses it (This needed generation of new golden files on the comet side given that plans are changed AFAIK) cc : @andygrove , @kazuyukitanimura -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
