parthchandra commented on code in PR #17376: URL: https://github.com/apache/datafusion/pull/17376#discussion_r2317464667
########## datafusion/common/src/scalar/mod.rs: ########## @@ -882,7 +882,7 @@ fn dict_from_scalar<K: ArrowDictionaryKeyType>( } /// Create a dictionary array representing all the values in values Review Comment: Do you think we should be modifying the description even though the change only modifies the visibility of the method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
