comphead commented on code in PR #17376:
URL: https://github.com/apache/datafusion/pull/17376#discussion_r2317039606
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -882,7 +882,7 @@ fn dict_from_scalar<K: ArrowDictionaryKeyType>(
}
/// Create a dictionary array representing all the values in values
Review Comment:
```suggestion
/// Create a `DictionaryArray` from the provided values array.
///
/// Each element gets a unique key (`0..N-1`), without deduplication.
/// Useful for wrapping arrays in dictionary form.
///
/// # Input
/// ["alice", "bob", "alice", null, "carol"]
///
/// # Output
/// DictionaryArray<Int32>
/// {
/// keys: [0, 1, 2, 3, 4],
/// values: ["alice", "bob", "alice", null, "carol"]
/// }
```
I think the current method description is confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
