coderfender commented on code in PR #2099:
URL: https://github.com/apache/datafusion-comet/pull/2099#discussion_r2318019979
##########
native/spark-expr/src/static_invoke/char_varchar_utils/read_side_padding.rs:
##########
@@ -43,17 +42,69 @@ fn spark_read_side_padding2(
match args {
[ColumnarValue::Array(array),
ColumnarValue::Scalar(ScalarValue::Int32(Some(length)))] => {
match array.data_type() {
- DataType::Utf8 =>
spark_read_side_padding_internal::<i32>(array, *length, truncate),
- DataType::LargeUtf8 => {
- spark_read_side_padding_internal::<i64>(array, *length,
truncate)
+ DataType::Utf8 => spark_read_side_padding_internal::<i32>(
+ array,
+ truncate,
+ ColumnarValue::Scalar(ScalarValue::Int32(Some(*length))),
+ ),
+ DataType::LargeUtf8 => spark_read_side_padding_internal::<i64>(
+ array,
+ truncate,
+ ColumnarValue::Scalar(ScalarValue::Int32(Some(*length))),
+ ),
+ // Dictionary support required for SPARK-48498
Review Comment:
Great catch! My understanding is that dictionary support ensures
SQL-compliant CHAR type literals, which always have a fixed length. Therefore,
my support for the array argument is obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
