gabotechs commented on code in PR #17378:
URL: https://github.com/apache/datafusion/pull/17378#discussion_r2318980266
##########
datafusion/proto/src/logical_plan/to_proto.rs:
##########
@@ -317,6 +317,7 @@ pub fn serialize_expr(
// TODO: support null treatment in proto
null_treatment: _,
distinct: _,
+ filter: _,
Review Comment:
> Hmm... which project might you be thinking about? ;)
🤷♂️ who knows.
> There is already the // TODO: support null treatment in proto above. I
hope whoever implements it will also pick up distinct and filter!
fair enough 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
