geoffreyclaude commented on PR #17378: URL: https://github.com/apache/datafusion/pull/17378#issuecomment-3254277786
> Would be nice to have a test via DataFrame API if possible. Also for the proto, I think we can raise an issue so we can have it tracked in GitHub. > > Should we also update somewhere in our SQL reference that we now support FILTERS in windows? I notice we don't mention FILTER support for regular aggregates either 🤔 > > Other than that, seems good to me. @Jefffrey Thanks for your review! I've added https://github.com/apache/datafusion/pull/17378/commits/ff0b1c8d7cb5bb4e80c8b7576f819961daa7ab0d for the DataFrame API test, and https://github.com/apache/datafusion/pull/17378/commits/8ce5de39122fb023f4f2de04253cf7bd1d54c883 for the docs if you want to give it another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
