alamb commented on issue #17297: URL: https://github.com/apache/datafusion/issues/17297#issuecomment-3254532336
> I believe we do not need to bring CachePhysicalExec to DataFusion, we just need to provide a LogicalPlan::Cache. That makes sense to me and the idea of being able to specially handle LogicalPlan nodes seems reasonable to me I dug around and it seems like we already do this for various DDL here: https://github.com/apache/datafusion/blob/cb69574c0ff326ff975c58234b124904add33cfc/datafusion/core/src/execution/context/mod.rs#L664-L663 What if we instead changed `DataFrame::cache` to use a `LogicalPlan::DDL` / `CreateMemoryTable` https://github.com/apache/datafusion/blob/a571b7d44436c5c2bf641444857e8358edd9d8a8/datafusion/expr/src/logical_plan/ddl.rs#L41-L40 Then ballista could use the same mechanism? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
