findepi commented on PR #17350: URL: https://github.com/apache/datafusion/pull/17350#issuecomment-3257599505
For normal functions, the Eq is not based on the Hash and is not susceptible to hash collisions. The hash can be pre-calculated and if it's different, then Eq can short-circuit before checking other fields. However, checking pre-calculated hash alone -- or _some fields_ and the pre-calculated hash -- is not a correct Eq implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
