findepi commented on PR #17350: URL: https://github.com/apache/datafusion/pull/17350#issuecomment-3257605231
You can think of this the following way. If I replace hash function with a function that always returns the same thing (e.g. `42`), is my code maybe slower, but still _correct_? If yes, we're good. However, looking at `impl PartialEq for ForeignAggregateUDF`, I don't think this is the case. So I don't think we're good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
