adriangb commented on code in PR #17452:
URL: https://github.com/apache/datafusion/pull/17452#discussion_r2330130677
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -1355,7 +1362,7 @@ async fn test_nested_hashjoin_dynamic_filter_pushdown() {
- DataSourceExec: file_groups={1 group: [[test.parquet]]},
projection=[a, x], file_type=test, pushdown_supported=true
- HashJoinExec: mode=Partitioned, join_type=Inner, on=[(c@1, d@0)]
- DataSourceExec: file_groups={1 group: [[test.parquet]]},
projection=[b, c, y], file_type=test, pushdown_supported=true,
predicate=DynamicFilterPhysicalExpr [ b@0 >= aa AND b@0 <= ab ]
- - DataSourceExec: file_groups={1 group: [[test.parquet]]},
projection=[d, z], file_type=test, pushdown_supported=true,
predicate=DynamicFilterPhysicalExpr [ d@0 >= ca AND d@0 <= ce ]
Review Comment:
Hmm the filter is more selective (generally a good thing) but I'm curious
why it changed, it's not immediately coming to me why waiting would change the
value of the filter. Could you help me understand why that is?
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/util.rs:
##########
@@ -77,6 +79,12 @@ impl FileOpener for TestOpener {
let (mapper, projection) =
factory.map_schema(&batches[0].schema()).unwrap();
let mut new_batches = Vec::new();
for batch in batches {
+ let batch = if let Some(predicate) = &self.predicate {
+ batch_filter(&batch, predicate)?
Review Comment:
Nice I didn't know this little function existed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
