alamb commented on code in PR #17452:
URL: https://github.com/apache/datafusion/pull/17452#discussion_r2333509183
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -294,3 +330,46 @@ impl fmt::Debug for SharedBoundsAccumulator {
write!(f, "SharedBoundsAccumulator")
}
}
+
+/// Utility future to wait until all partitions have reported completion
Review Comment:
This looks very similar to a `Barrier` --
https://docs.rs/tokio/latest/tokio/sync/struct.Barrier.html
Maybe as a follow on PR we could simplify the code a bit by potentially
using that pre-defied structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
