xanderbailey commented on code in PR #17299:
URL: https://github.com/apache/datafusion/pull/17299#discussion_r2329515274
##########
datafusion/substrait/tests/cases/logical_plans.rs:
##########
@@ -144,6 +144,47 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn null_literal_before_and_after_joins() -> Result<()> {
+ // Confirms that literals used before and after a join but for
different columns
+ // are correctly handled.
+
+ // File generated with substrait-java's Isthmus:
+ // ./isthmus-cli/build/graal/isthmus --create "create table A (a int);
create table B (a int, c int); create table C (a int, d int)" "select t.*, C.d,
CAST(NULL AS VARCHAR) as e from (select a, CAST(NULL AS VARCHAR) as c from A
UNION ALL select a, c from B) t LEFT JOIN C ON t.a = C.a"
+ let proto_plan =
+
read_json("tests/testdata/test_plans/null_literals.substrait.json");
Review Comment:
Changed to `disambiguate_literals_with_same_name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
