alamb commented on code in PR #17332:
URL: https://github.com/apache/datafusion/pull/17332#discussion_r2352180183
##########
.github/workflows/rust.yml:
##########
@@ -579,7 +579,7 @@ jobs:
with:
rust-version: stable
- name: Run datafusion-common tests
- run: cargo test --profile ci -p datafusion-common --features=pyarrow
+ run: cargo test --profile ci -p datafusion-common
--features=pyarrow,sql
Review Comment:
I reviewed the existing coverage and it seems like the current pattern is to
test features in CI here:
https://github.com/apache/datafusion/blob/49d49fd92dddf55bfb22787fea17dda1a698dc4d/.github/workflows/rust.yml#L188-L187
I took the liberty of adding the appropriate entry for the `sql` feature in
this PR and documeting the feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
