findepi commented on code in PR #17332:
URL: https://github.com/apache/datafusion/pull/17332#discussion_r2355651752
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -301,6 +302,59 @@ pub(crate) fn parse_identifiers_normalized(s: &str,
ignore_case: bool) -> Vec<St
.collect::<Vec<_>>()
}
+#[cfg(not(feature = "sql"))]
+pub(crate) fn parse_identifiers(s: &str) -> Result<Vec<String>> {
Review Comment:
I don't think we should have two different, divergent implementations of
parse_identifiers and parse_identifiers_normalized. This leads to unpredictable
runtime behavior when integrating different components using DataFusion (one
using `sql` feature and one not).
If the new implementation is equivalent to sqlparser-based, it should be the
only implementation.
If it is not, it should not exist. All the APIs using it should be guarded
by `sql` feature flag.
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -301,6 +302,59 @@ pub(crate) fn parse_identifiers_normalized(s: &str,
ignore_case: bool) -> Vec<St
.collect::<Vec<_>>()
}
+#[cfg(not(feature = "sql"))]
+pub(crate) fn parse_identifiers(s: &str) -> Result<Vec<String>> {
Review Comment:
- https://github.com/apache/datafusion/issues/17623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
