H0TB0X420 commented on code in PR #1241:
URL:
https://github.com/apache/datafusion-python/pull/1241#discussion_r2356326534
##########
python/datafusion/dataframe.py:
##########
@@ -370,6 +375,39 @@ def schema(self) -> pa.Schema:
Describing schema of the DataFrame
"""
return self.df.schema()
+
+ def to_batches(self) -> list[pa.RecordBatch]:
+ """Convert DataFrame to list of RecordBatches."""
+ return self.collect() # delegate to existing method
+
+ def interpolate(self, method: str = "forward_fill", **kwargs) -> DataFrame:
+ """Interpolate missing values per column.
+
+ Args:
+ method: Interpolation method ('linear', 'forward_fill',
'backward_fill')
Review Comment:
Two quick questions:
1. Should we have separate methods for filling vs interpolation?
2. Do we wait for DataFusion core features before adding Python APIs, or is
it okay to create stand-in Python implementations using existing primitives?
Thank you for your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
