H0TB0X420 commented on code in PR #1241:
URL:
https://github.com/apache/datafusion-python/pull/1241#discussion_r2356344778
##########
python/datafusion/dataframe.py:
##########
@@ -370,6 +375,39 @@ def schema(self) -> pa.Schema:
Describing schema of the DataFrame
"""
return self.df.schema()
+
+ def to_batches(self) -> list[pa.RecordBatch]:
+ """Convert DataFrame to list of RecordBatches."""
+ return self.collect() # delegate to existing method
Review Comment:
I could do a try-except to throw an ImportError if it is not installed. But
it might make more sense to drop `to_batches()` from this PR given the
dependency discussion. I don't want to add to the PyArrow dependency concerns.
I'll remove it and focus on fixing the `interpolate()` implementation. I
appreciate you taking the time to give feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
