pepijnve commented on code in PR #17419:
URL: https://github.com/apache/datafusion/pull/17419#discussion_r2337775769
##########
datafusion/catalog/src/stream.rs:
##########
@@ -321,24 +324,26 @@ impl TableProvider for StreamTable {
async fn scan(
&self,
- _state: &dyn Session,
+ state: &dyn Session,
projection: Option<&Vec<usize>>,
_filters: &[Expr],
limit: Option<usize>,
) -> Result<Arc<dyn ExecutionPlan>> {
- let projected_schema = match projection {
- Some(p) => {
- let projected = self.0.source.schema().project(p)?;
- create_ordering(&projected, &self.0.order)?
- }
- None => create_ordering(self.0.source.schema(), &self.0.order)?,
+ let schema = self.0.source.schema();
+ let df_schema = DFSchema::try_from(Arc::clone(schema))?;
Review Comment:
I was a bit concerned about the waste here as well, but I couldn't figure
out a simple way to avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
