parthchandra commented on code in PR #2412:
URL: https://github.com/apache/datafusion-comet/pull/2412#discussion_r2361297496
##########
spark/src/main/scala/org/apache/comet/ExtendedExplainInfo.scala:
##########
@@ -137,18 +161,37 @@ class ExtendedExplainInfo extends
ExtendedExplainGenerator {
depth + 1,
lastChildren :+ false,
indent,
- outString)
+ outString,
+ planStats)
case _ =>
}
node.children.last match {
case c @ (_: TreeNode[_]) =>
- generateTreeString(getActualPlan(c), depth + 1, lastChildren :+
true, indent, outString)
+ generateTreeString(
+ getActualPlan(c),
+ depth + 1,
+ lastChildren :+ true,
+ indent,
+ outString,
+ planStats)
case _ =>
}
}
}
}
+class PlanStats {
+ var sparkOperators: Int = 0
+ var cometOperators: Int = 0
+ var wrappers: Int = 0
+ var transitions: Int = 0
+
+ override def toString: String = {
+ s"sparkOperators=$sparkOperators, cometOperators=$cometOperators, " +
Review Comment:
Perhaps we could use a more verbose string here so that the meaning of these
stats is a little more obvious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
